Change in libosmocore[master]: logging: gsmtap: Fill PID field for each message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 15 12:06:27 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22920 )

Change subject: logging: gsmtap: Fill PID field for each message
......................................................................


Patch Set 1:

Actually, I would probably have gone for a static global variable, as

a) the PID is not different between multiple targets
b) it doesn't change the ABI

But given we are hopefully soon tagging a new release with tons of other ABI breakage, I guess we can overlook the second one.

One idea might be to use the thread ID instead... not sure if that would be interesting in osmoTRX?. t that point it would be a static global __thread variable.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22920
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7db00d1810f0860166bffa0bda8566caa82e06a9
Gerrit-Change-Number: 22920
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 15 Feb 2021 12:06:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210215/e2eb7ce8/attachment.htm>


More information about the gerrit-log mailing list