Change in osmo-bts[master]: l1sap: be sure that the DL-SACCH l1 header is also repeated

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Feb 13 07:45:31 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22887 )

Change subject: l1sap: be sure that the DL-SACCH l1 header is also repeated
......................................................................


Patch Set 1: Code-Review+1

the API becomes even more awkward than it alrady is with that. Might be worth investigating a method where we could simply push those fields to the frong of the msgb, and/or possibly even recycle the msgb and elimiate the memcpy to another msgb altogether.  Yes, that's more like a separte patch, just noticing that it's really odd that we store two bytes extra somewhere else when we actually have a msgb that can hold all of this...


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22887
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6ae601c84dd0df0c9ae142c3295da36f3222b0c9
Gerrit-Change-Number: 22887
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 13 Feb 2021 07:45:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210213/c1879ea8/attachment.htm>


More information about the gerrit-log mailing list