This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22889 ) Change subject: bssgp_bvc_fsm: Consistent naming ...................................................................... bssgp_bvc_fsm: Consistent naming bssgp_bvc_get_features_* are fsm "methods" and the name should indicate that just lika all other function names in bssgp_bvc_fsm.h Change-Id: I30fbbe36cdabf9635eaf4dfb1e93c8ce0f667b39 --- M include/osmocom/gprs/bssgp_bvc_fsm.h M src/gb/bssgp_bvc_fsm.c M src/gb/libosmogb.map 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gprs/bssgp_bvc_fsm.h b/include/osmocom/gprs/bssgp_bvc_fsm.h index 824cdec..446dda8 100644 --- a/include/osmocom/gprs/bssgp_bvc_fsm.h +++ b/include/osmocom/gprs/bssgp_bvc_fsm.h @@ -61,9 +61,9 @@ uint8_t bssgp_bvc_fsm_get_block_cause(struct osmo_fsm_inst *fi); -uint32_t bssgp_bvc_get_features_advertised(struct osmo_fsm_inst *fi); -uint32_t bssgp_bvc_get_features_received(struct osmo_fsm_inst *fi); -uint32_t bssgp_bvc_get_features_negotiated(struct osmo_fsm_inst *fi); +uint32_t bssgp_bvc_fsm_get_features_advertised(struct osmo_fsm_inst *fi); +uint32_t bssgp_bvc_fsm_get_features_received(struct osmo_fsm_inst *fi); +uint32_t bssgp_bvc_fsm_get_features_negotiated(struct osmo_fsm_inst *fi); void bssgp_bvc_fsm_set_max_pdu_len(struct osmo_fsm_inst *fi, uint16_t max_pdu_len); uint16_t bssgp_bvc_fsm_get_max_pdu_len(const struct osmo_fsm_inst *fi); \ No newline at end of file diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c index a035938..8d284d1 100644 --- a/src/gb/bssgp_bvc_fsm.c +++ b/src/gb/bssgp_bvc_fsm.c @@ -794,7 +794,7 @@ } /*! Return the advertised features / extended features. */ -uint32_t bssgp_bvc_get_features_advertised(struct osmo_fsm_inst *fi) +uint32_t bssgp_bvc_fsm_get_features_advertised(struct osmo_fsm_inst *fi) { struct bvc_fsm_priv *bfp = fi->priv; @@ -803,7 +803,7 @@ } /*! Return the received features / extended features. */ -uint32_t bssgp_bvc_get_features_received(struct osmo_fsm_inst *fi) +uint32_t bssgp_bvc_fsm_get_features_received(struct osmo_fsm_inst *fi) { struct bvc_fsm_priv *bfp = fi->priv; @@ -812,7 +812,7 @@ } /*! Return the negotiated features / extended features. */ -uint32_t bssgp_bvc_get_features_negotiated(struct osmo_fsm_inst *fi) +uint32_t bssgp_bvc_fsm_get_features_negotiated(struct osmo_fsm_inst *fi) { struct bvc_fsm_priv *bfp = fi->priv; diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map index 2327815..699ed1b 100644 --- a/src/gb/libosmogb.map +++ b/src/gb/libosmogb.map @@ -93,9 +93,9 @@ bssgp_bvc_fsm_set_ops; bssgp_bvc_fsm_is_unblocked; bssgp_bvc_fsm_get_block_cause; -bssgp_bvc_get_features_advertised; -bssgp_bvc_get_features_received; -bssgp_bvc_get_features_negotiated; +bssgp_bvc_fsm_get_features_advertised; +bssgp_bvc_fsm_get_features_received; +bssgp_bvc_fsm_get_features_negotiated; bssgp_bvc_fsm_set_max_pdu_len; bssgp_bvc_fsm_get_max_pdu_len; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I30fbbe36cdabf9635eaf4dfb1e93c8ce0f667b39 Gerrit-Change-Number: 22889 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210213/3e1b0b68/attachment.htm>