This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857 ) Change subject: pcu: Introduce several tests TC_nacc_outbound_pkt_cell_chg_notif_dup* ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857/1/pcu/PCU_Tests.ttcn@4285 PS1, Line 4285: cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi, req_arfcn, req_bsic); > I know next to nothing of NACC but it seems to me like you could refactor the code above into a sepa […] I already thought about it but in general most of the stuf above is already test specific stuff like initing different parts for the test (RLCMAC, BSSGP, etc.) and hence it's not something really to be applied for this bunch of new tests but to most of the tests, so I'd leave it for a different patch. Moreover, one finds that some variables here are later on used by the code below, so it also makes some stuff more complex because then one needs to retrieve the variable back from the new propose _nacc_init function. Also some nacc test have slight differences here since for instance the neigh cache is initialized differently on some tests. So I'm not sure it's a super benefit, and in any case I think it can be done at a later step for all tests in general if required. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib83eacfab7a73a2a51ab08801ff1c00c0058057c Gerrit-Change-Number: 22857 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Comment-Date: Fri, 12 Feb 2021 14:40:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/567cdda2/attachment.htm>