This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22862 ) Change subject: l1sap: be sure that UL-SACCH repetition is turned off ...................................................................... l1sap: be sure that UL-SACCH repetition is turned off At the beginning of repeated_ul_sacch_active_decision() The UL-SACCH repetition capability is tested. If no UL-SACCH repetition is enabled the function exits. However, we should also make sure that the struct member that enabled UL-SACCH repetition on the lower level is set to false as well. Normally that should be the case because it was never set to true before, but it is better to be sure. Change-Id: I76a841514eb955b93f2114470b2c80402cf6883c Related: SYS#5114 --- M src/common/l1sap.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 3de76ab..97dd661 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1427,8 +1427,14 @@ uint16_t upper = 0; uint16_t lower = 0; - if (!lchan->repeated_acch_capability.ul_sacch) + /* This is an optimization so that we exit as quickly as possible if + * there are no uplink SACCH repetition capabilities present. + * However If the repeated UL-SACCH capabilities vanish for whatever + * reason, we must be sure that UL-SACCH repetition is disabled. */ + if (!lchan->repeated_acch_capability.ul_sacch) { + lchan->repeated_ul_sacch_active = false; return; + } /* Threshold disabled (repetition is always on) */ if (lchan->repeated_acch_capability.rxqual == 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76a841514eb955b93f2114470b2c80402cf6883c Gerrit-Change-Number: 22862 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/2b644c0d/attachment.htm>