Change in osmo-bts[master]: l1sap: fix repeated_dl_facch_active_decision()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Feb 12 09:30:19 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22860 )

Change subject: l1sap: fix repeated_dl_facch_active_decision()
......................................................................

l1sap: fix repeated_dl_facch_active_decision()

The function checks meas_res->rxqual_sub against the lower threshold
value in order to decide when to turn FACCH repetition off. This is not
correct. It should compare against rxqual instead.

Change-Id: Id4ab101d52f419583c4f4c8a6cf69af6c9097d25
Related: SYS#5114
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 1542c8a..b6970f4 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1025,7 +1025,7 @@
 
 	if (rxqual >= upper)
 		lchan->repeated_dl_facch_active = true;
-	else if (meas_res->rxqual_sub <= lower)
+	else if (rxqual <= lower)
 		lchan->repeated_dl_facch_active = false;
 
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22860
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id4ab101d52f419583c4f4c8a6cf69af6c9097d25
Gerrit-Change-Number: 22860
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/67d955e0/attachment.htm>


More information about the gerrit-log mailing list