Change in osmo-pcu[master]: nacc_fsm: Remove NACC_EV_RX_SI from in_event_mask of some states

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Feb 11 17:49:42 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22847 )

Change subject: nacc_fsm: Remove NACC_EV_RX_SI from in_event_mask of some states
......................................................................

nacc_fsm: Remove NACC_EV_RX_SI from in_event_mask of some states

We don't care about those messages anymore if we already transitioned
further than NACC_ST_WAIT_REQUEST_SI. Furthermore, RIM code dispatching
the event to the FSM is only doing it in the mentioned state above.

Related: SYS#4909
Change-Id: If420b49e437ff02073669522408763e5e84fe477
---
M src/nacc_fsm.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c
index f9dea98..99c8164 100644
--- a/src/nacc_fsm.c
+++ b/src/nacc_fsm.c
@@ -610,7 +610,6 @@
 	[NACC_ST_TX_NEIGHBOUR_DATA] = {
 		.in_event_mask =
 			X(NACC_EV_RX_CELL_CHG_NOTIFICATION) |
-			X(NACC_EV_RX_SI) |
 			X(NACC_EV_CREATE_RLCMAC_MSG),
 		.out_state_mask =
 			X(NACC_ST_TX_CELL_CHG_CONTINUE),
@@ -620,7 +619,6 @@
 	[NACC_ST_TX_CELL_CHG_CONTINUE] = {
 		.in_event_mask =
 			X(NACC_EV_RX_CELL_CHG_NOTIFICATION) |
-			X(NACC_EV_RX_SI) |
 			X(NACC_EV_CREATE_RLCMAC_MSG),
 		.out_state_mask =
 			X(NACC_ST_WAIT_CELL_CHG_CONTINUE_ACK),

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22847
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If420b49e437ff02073669522408763e5e84fe477
Gerrit-Change-Number: 22847
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/dc85f095/attachment.htm>


More information about the gerrit-log mailing list