Change in docker-playground[master]: debian-stretch-titan: update deps on change

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Feb 11 15:06:06 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22818 )

Change subject: debian-stretch-titan: update deps on change
......................................................................

debian-stretch-titan: update deps on change

After the initial clone of osmo-ttcn3-hacks and deps, let docker
download deps/Makefile to invalidate the cache if the file changed.

Run "git pull" and "make deps" afterwards, but only if the Makefile is
different. The "if" saves time in the initial build of the image, it
avoids the "git fetch" on every dependency repository during "make deps".

Related: OS#5017
Change-Id: I56673312cfb23375d67900016aaac1931f677275
---
M debian-stretch-titan/Dockerfile
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  osmith: Looks good to me, approved; Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve



diff --git a/debian-stretch-titan/Dockerfile b/debian-stretch-titan/Dockerfile
index 0f4f17e..39ff76f 100644
--- a/debian-stretch-titan/Dockerfile
+++ b/debian-stretch-titan/Dockerfile
@@ -52,6 +52,12 @@
 RUN	git config --global user.email docker at dock.er && \
 	git config --global user.name "Dock Er"
 
-# clone osmo-ttcn3-hacks and deps
+# clone osmo-ttcn3-hacks and deps, invalidate cache if deps change (OS#5017)
 RUN	git clone git://git.osmocom.org/osmo-ttcn3-hacks.git && \
 	make -C /osmo-ttcn3-hacks deps
+ADD	https://git.osmocom.org/osmo-ttcn3-hacks/plain/deps/Makefile /tmp/deps-Makefile
+RUN	if ! diff -q /tmp/deps-Makefile /osmo-ttcn3-hacks/deps/Makefile; then \
+		cd /osmo-ttcn3-hacks && \
+		git pull && \
+		make deps; \
+	fi

-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22818
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I56673312cfb23375d67900016aaac1931f677275
Gerrit-Change-Number: 22818
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/df141465/attachment.htm>


More information about the gerrit-log mailing list