Change in osmo-ttcn3-hacks[master]: gbproxy: Fix TC_dl_unitdata test failure introduced by 6ee0126971

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Feb 11 13:43:39 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845 )

Change subject: gbproxy: Fix TC_dl_unitdata test failure introduced by 6ee0126971
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845/1/library/Osmocom_Gb_Types.ttcn 
File library/Osmocom_Gb_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845/1/library/Osmocom_Gb_Types.ttcn@1026 
PS1, Line 1026: template IMSI_BSSGP tr_BSSGP_IMSI(template hexstring imsi) := {
why that change?  The template does not return a * type wild card, so it is by definition always 'present'?  So it is "consistent" before this change, but now after the change it appears to do support something that it cannot in its current form (e.g. acceptiong imsi:=*)

I guess you'd need to create a function retunring a template and use the usual 'istemplatekind' approach?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I85676e96f8d32a9d2c7deadc1d66707b6b8697d0
Gerrit-Change-Number: 22845
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Feb 2021 13:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/a722f20c/attachment.htm>


More information about the gerrit-log mailing list