This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804 ) Change subject: gb_proxy: add support for relaying BSSGP RIM messages ...................................................................... Patch Set 3: Code-Review+1 (7 comments) https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@939 PS1, Line 939: shoud > should Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@942 PS1, Line 942: LOGP(DLBSSGP, LOGL_DEBUG, "%s %s relaying RIM-PDU: src=%s, dest=%s\n", log_pfx, pdut_name, > Could you vary the log lines so they indicate which path is taken? […] Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@946 PS1, Line 946: LOGP(DGPRS, LOGL_NOTICE, > I don't think we need this log at all and if we do it should be DEBUG. […] Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@961 PS1, Line 961: LOGP(DLBSSGP, LOGL_DEBUG, "%s %s relaying RIM-PDU: src=%s, dest=%s\n", log_pfx, pdut_name, > "relaying RIM-PDU to SGSN(%05u/%s) "... […] Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@1236 PS1, Line 1236: target GERAN > "target non-GERAN cells" Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@1243 PS1, Line 1243: /* TODO: Reply with STATUS if BSSGP didn't negotiate RIM feature, see also comments in > When this is implemented it should be done as first step. […] Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804/1/src/gb_proxy.c@1256 PS1, Line 1256: LOGP(DLBSSGP, LOGL_DEBUG, "%s %s relaying RIM-PDU: src=%s, dest=%s\n", log_pfx, pdut_name, > "relaying RIM-PDU from SGSN(%05u/%s) " ... Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Idd1ea46832e044f0ade15af32250f90517d848d8 Gerrit-Change-Number: 22804 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 10 Feb 2021 16:04:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210210/a6774cec/attachment.htm>