Change in osmo-pcu[master]: Use ALPHA value received in SI13 from PCUIF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Feb 9 19:07:49 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22801 )

Change subject: Use ALPHA value received in SI13 from PCUIF
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/doc/manuals/chapters/configuration.adoc@216 
PS1, Line 216: Parameter `ALPHA` is set on the BSC VTY configuration file on a per-BTS basis,
Please also clarify here that presence of 'alpha <0-10>' in the config file makes osmo-pcu ignore the value received from the BSC. Some users tend to ignore deprecation warnings...


https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c 
File src/pcu_vty.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c@234 
PS1, Line 234: 	vty_out(vty, " alpha %u%s", the_pcu->vty.force_alpha, VTY_NEWLINE);
code formatting


https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c@746 
PS1, Line 746: 		the_pcu->vty.force_alpha = atoi(argv[0]);
How about printing a warning that presence of 'alpha <0-10>' in the configuration file makes osmo-pcu ignore the value received from the BSC?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22801
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I46f2a955b157a409055fca7fb917dc4f75482426
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Feb 2021 19:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/cb01a38e/attachment.htm>


More information about the gerrit-log mailing list