This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22798 ) Change subject: cosmetic: Move comment one line below in append_gprs_cell_opt ...................................................................... cosmetic: Move comment one line below in append_gprs_cell_opt Move it above the place where the bit is set, since the bit represents whether Extension Information is available, not whether R99 is available. Change-Id: Ice592acc50a24efd7fe4cf1a91f1d48fd74f38d8 --- M src/gsm/gsm48_rest_octets.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/22798/1 diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index f45e818..1bab8e0 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -906,9 +906,8 @@ bitvec_set_bit(bv, 0); } else { /* extension information */ - - /* R99 extension: */ bitvec_set_bit(bv, 1); + /* R99 extension: */ if (!gco->ext_info.egprs_supported) { /* 6bit length of extension */ bitvec_set_uint(bv, (1 + 5)-1, 6); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ice592acc50a24efd7fe4cf1a91f1d48fd74f38d8 Gerrit-Change-Number: 22798 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/fd23c6c9/attachment.htm>