This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22671 ) Change subject: gb_proxy_peer: Require ra_id and cid in gbproxy_cell_alloc ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-gbproxy/+/22671/1/include/osmocom/sgsn/gb_proxy.h File include/osmocom/sgsn/gb_proxy.h: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22671/1/include/osmocom/sgsn/gb_proxy.h@225 PS1, Line 225: LOGP(SUBSYS, LEVEL, "CELL(%05u/%05u) " FMT, (CELL)->bvci, (CELL)->id.cid, ## ARGS) > is the CI enough to show the cell? I bet no. You should be printing the RAI+CI as "%u-%u-%u-... […] BVCI should already be unique. But yeah, your format makes more sense. I'd suggest to just remove this change and we'll have it in a separate commit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22671/2/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22671/2/src/gb_proxy.c@671 PS2, Line 671: > Do we use bvc->raid or the raid from the parameter list here? The old version of this patch used rai […] The parameter ra_id is definitely the one the BVC reported with its BVC reset. This code leads to an inconsistent state if an existing BVC sends a BVC reset with a different raid than before. However, in line 874 we sort-of fix it up. The cell and bvc ra_ids might be different in that case as well. Let's keep it as it was and worry about it in a separate issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ic7deae5ccf839b941d70557d28451d52f32cebbb Gerrit-Change-Number: 22671 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 09 Feb 2021 17:24:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/a66ebfda/attachment.htm>