Change in osmo-gbproxy[master]: gb_proxy_peer: Add Function to get gbproxy cell by cell id

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652 )

Change subject: gb_proxy_peer: Add Function to get gbproxy cell by cell id
......................................................................


Patch Set 5:

> Patch Set 5:
> 
> > Patch Set 4:
> > 
> > The libosmocore change-id has been merged 4 days ago, but this one still fails.
> > 
> > gb_proxy_peer.c:215:11: error: ‘struct gbproxy_cell’ has no member named ‘id’
> >    if (cell->id.cid == cid && gsm48_compare_ra(&cell->id.raid, raid) == 0) {
> >            ^~
> > gb_proxy_peer.c:215:30: error: implicit declaration of function ‘gsm48_compare_ra’ [-Werror=implicit-function-declaration]
> >    if (cell->id.cid == cid && gsm48_compare_ra(&cell->id.raid, raid) == 0) {
> >                               ^~~~~~~~~~~~~~~~
> > gb_proxy_peer.c:215:52: error: ‘struct gbproxy_cell’ has no member named ‘id’
> >    if (cell->id.cid == cid && gsm48_compare_ra(&cell->id.raid, raid) == 0) {
> >                                                     ^~
> 
> This is strange. Now it builds fine against master. Maybe gsm48_compare_ra() was in a different patch.

I see now: It was most likely an issue with renaming gsm48_compare_ra to gsm48_ra_equal.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I3403736eed9d6819634c26db0b90393ac6f4416a
Gerrit-Change-Number: 22652
Gerrit-PatchSet: 5
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Feb 2021 12:05:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/e80cecf1/attachment.htm>