Change in osmo-ttcn3-hacks[master]: pcu: Fix warning: control reaches end of non-void function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 8 17:13:17 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22736 )

Change subject: pcu: Fix warning: control reaches end of non-void function
......................................................................

pcu: Fix warning: control reaches end of non-void function

Change-Id: I2c8b343fba5fabda9f78af8711e2a837536518e9
---
M pcu/GPRS_TBF.ttcn
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pcu/GPRS_TBF.ttcn b/pcu/GPRS_TBF.ttcn
index f946f29..3794410 100644
--- a/pcu/GPRS_TBF.ttcn
+++ b/pcu/GPRS_TBF.ttcn
@@ -14,6 +14,7 @@
 import from GSM_Types all;
 import from Osmocom_Types all;
 import from General_Types all;
+import from Misc_Helpers all;
 import from RLCMAC_CSN1_Types all;
 import from RLCMAC_Types all;
 import from RLCMAC_Templates all;
@@ -409,8 +410,9 @@
 }
 
 function f_dl_tbf_is_in_window(integer bsn) return boolean {
-	setverdict(fail, "pleaes implement me");
-	mtc.stop;
+	Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+				"please implement me");
+	return false;
 }
 
 function f_dl_tbf_is_received(inout DlTbfState ds, integer bsn) return boolean {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22736
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2c8b343fba5fabda9f78af8711e2a837536518e9
Gerrit-Change-Number: 22736
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/82d3f3f0/attachment.htm>


More information about the gerrit-log mailing list