Change in osmo-ttcn3-hacks[master]: GSM_Types: Fix warning: control reaches end of non-void function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 8 17:13:17 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22735 )

Change subject: GSM_Types: Fix warning: control reaches end of non-void function
......................................................................

GSM_Types: Fix warning: control reaches end of non-void function

Change-Id: I749fe3a2ca85ae96fa74a78f15180cfaa02ffe84
---
M library/GSM_Types.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn
index 9710c26..bcd0afb 100644
--- a/library/GSM_Types.ttcn
+++ b/library/GSM_Types.ttcn
@@ -14,6 +14,7 @@
 
 import from General_Types all;
 import from Osmocom_Types all;
+import from Misc_Helpers all;
 
 type integer GsmArfcn (0..1023);
 type integer UmtsArfcn (0..16383);
@@ -86,11 +87,10 @@
 	case (CS2) { return 32 }
 	case (CS3) { return 38 }
 	case (CS3) { return 52 }
-	case else {
-		setverdict(fail, "Invalid GPRS CS ", cs);
-		mtc.stop;
-		}
 	}
+	Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+				log2str("Invalid GPRS CS ", cs));
+	return 0;
 }
 
 const GprsTlli TLLI_UNUSED := 'FFFFFFFF'O;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22735
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I749fe3a2ca85ae96fa74a78f15180cfaa02ffe84
Gerrit-Change-Number: 22735
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/89139f5b/attachment.htm>


More information about the gerrit-log mailing list