Change in osmo-ttcn3-hacks[master]: CTRL: Avoid using keyword 'now' as var

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 8 17:13:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22725 )

Change subject: CTRL: Avoid using keyword 'now' as var
......................................................................

CTRL: Avoid using keyword 'now' as var

Fixes warning: Keyword 'now' is treated as an identifier. Activate
compiler option '-I' to use real-time testing features

Change-Id: I2b350bc93b33f36f72d35cb48d01f6c37ac1630f
---
M library/Osmocom_CTRL_Functions.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn
index 294fe33..15cb26f 100644
--- a/library/Osmocom_CTRL_Functions.ttcn
+++ b/library/Osmocom_CTRL_Functions.ttcn
@@ -268,14 +268,14 @@
 	 * Set the test verdict accordingly. */
 	function f_counter_name_vals_expect(IPA_CTRL_PT pt, charstring instance_name, integer instance_nr,
 					    CounterNameVals vals) {
-		var CounterNameVals now := f_counter_name_vals_get(pt, instance_name, instance_nr, vals);
+		var CounterNameVals last := f_counter_name_vals_get(pt, instance_name, instance_nr, vals);
 		for (var integer i := 0; i < lengthof(vals); i := i + 1) {
-			if (now[i].name != vals[i].name) {
+			if (last[i].name != vals[i].name) {
 				setverdict(fail, "Internal error");
 			}
-			if (now[i].val != vals[i].val) {
+			if (last[i].val != vals[i].val) {
 				setverdict(fail, "Rate counter mismatch: ", instance_name, " ", instance_nr,
-					   " ", vals[i].name, " is at ", now[i].val, " but expected ", vals[i].val);
+					   " ", vals[i].name, " is at ", last[i].val, " but expected ", vals[i].val);
 			}
 		}
 		setverdict(pass);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22725
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2b350bc93b33f36f72d35cb48d01f6c37ac1630f
Gerrit-Change-Number: 22725
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/932bf1b0/attachment.htm>


More information about the gerrit-log mailing list