Change in libosmo-sccp[master]: sccp: Add minimalistic SCMG implementation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 8 17:11:33 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/22789 )

Change subject: sccp: Add minimalistic SCMG implementation
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/22789/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/22789/1//COMMIT_MSG@10 
PS1, Line 10: at SSN=1.  In Osmcoom we so far ignored its existence.  However,
> Osmocom
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22789/1/src/sccp_scmg.c 
File src/sccp_scmg.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/22789/1/src/sccp_scmg.c@192 
PS1, Line 192: 		/* PC is encoded in little endian ?!? */
> does this mean you tested against some implementation not following our expectations?
no, this means I'm extremely surprised to see that in the specs the byte order for the PC is little-endian, while normally everything is big-endian.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/22789
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I04b162476f7652ef0540b5ea7299e9447efd1d09
Gerrit-Change-Number: 22789
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Feb 2021 17:11:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/f71937c9/attachment.htm>


More information about the gerrit-log mailing list