Change in osmo-gsm-tester[master]: srslte_common: add helper method to only get stdout KPIs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Feb 8 16:58:48 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22600 )

Change subject: srslte_common: add helper method to only get stdout KPIs
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22600/3/src/osmo_gsm_tester/obj/srslte_common.py 
File src/osmo_gsm_tester/obj/srslte_common.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22600/3/src/osmo_gsm_tester/obj/srslte_common.py@50 
PS3, Line 50:     def get_stdout_kpis(self):
I'm in general not happy to see new public APIs like this popping up (is it public to be used by tests? it's not clear here. It makes it harder to later on support new implementations of object classes.

In case of this being a public API, what's the benefit of having this public and not gathering all the KPIs from test through "get_kpis()"?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4bacc6b8a0cb92a581edfb947100b57022265265
Gerrit-Change-Number: 22600
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Feb 2021 16:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/99c05acd/attachment.htm>


More information about the gerrit-log mailing list