Change in libosmo-sccp[master]: xua: Implement SNM availability/unavailability messaging

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/22777 )

Change subject: xua: Implement SNM availability/unavailability messaging
......................................................................


Patch Set 2:

(9 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1//COMMIT_MSG@10 
PS1, Line 10: SG informs the ASP about certain desetinations (point codes) becoming
> destinations
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/m3ua.c 
File src/m3ua.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/m3ua.c@777 
PS1, Line 777: 		xua_msg_add_data(xua, M3UA_IEI_ROUTE_CTX, num_rctx * 4, (const uint8_t *)rctx);
> * sizeof(*rctx) would be clearer.
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/m3ua.c@779 
PS1, Line 779: 	xua_msg_add_data(xua, M3UA_IEI_AFFECTED_PC, num_aff_pc * 4, (const uint8_t *) aff_pc);
> same for aff_pc
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/m3ua.c@817 
PS1, Line 817: //struct xua_msg *m3ua_encode_dupu() { }
> This line can be dropped?
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/m3ua.c@820 
PS1, Line 820:  *  \param[in] asp ASP through whihc to transmit message. Must be ACTIVE.
> typo: which
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/m3ua.c@825 
PS1, Line 825:  *  \param[in] info_string optional information strng (can be NULL).
> typo: string
Done


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/xua_snm.c 
File src/xua_snm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/xua_snm.c@57 
PS1, Line 57: 		out = talloc_asprintf_append(out, "%s%s/%u, ", i == 0 ? "" : ", ",
> I assume this frees+malloc new string?
it performs talloc_realloc() internally as needed.


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/xua_snm.c@70 
PS1, Line 70: 	llist_for_each_entry(as, &asp->inst->as_list, list) {
> You are missing buffer overflow check against rctx_size here.
Ack


https://gerrit.osmocom.org/c/libosmo-sccp/+/22777/1/src/xua_snm.c@118 
PS1, Line 118: 		/* this can happen if the given ASP is only in the as that reports the change,
> AS
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/22777
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Id92be4691b0fd77598a6edb642c028bbd8c5b623
Gerrit-Change-Number: 22777
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Feb 2021 11:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/45dba521/attachment.htm>