This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/22772 ) Change subject: xua_msg: Add xua_msg*_get_str() to obtain string IE ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/22772/1/src/xua_msg.c File src/xua_msg.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/22772/1/src/xua_msg.c@306 PS1, Line 306: /* RFC3868 3.9.4: Length of the INFO String parameter is from 0 to 255 octets */ > It may make sense to have this 256 as a define in some include, having reference to this spec. as we only use it here, in this function, and the comment is just three lines below, I wouldn't bother. https://gerrit.osmocom.org/c/libosmo-sccp/+/22772/1/src/xua_msg.c@319 PS1, Line 319: return NULL; > does it make sense returning NULL here? or ""? I wanted to distinguish the situation where an empty tring was received, or no IE was present at all. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/22772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8cbb7aeaf0cb64db0ce01c21e5fca9ab3cd932b6 Gerrit-Change-Number: 22772 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 10:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/a17b25f1/attachment.htm>