This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/22770 ) Change subject: xua_msg: const-ify input arguments to xua_*_get_u32() ...................................................................... xua_msg: const-ify input arguments to xua_*_get_u32() Change-Id: I517943bd11d73195de9418fb1c5d4151dab77873 --- M include/osmocom/sigtran/xua_msg.h M src/xua_msg.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/sigtran/xua_msg.h b/include/osmocom/sigtran/xua_msg.h index 090d84e..a2cdbf2 100644 --- a/include/osmocom/sigtran/xua_msg.h +++ b/include/osmocom/sigtran/xua_msg.h @@ -89,8 +89,8 @@ int msgb_t16l16vp_put(struct msgb *msg, uint16_t tag, uint16_t len, const uint8_t *data); int msgb_t16l16vp_put_u32(struct msgb *msg, uint16_t tag, uint32_t val); int xua_msg_add_u32(struct xua_msg *xua, uint16_t iei, uint32_t val); -uint32_t xua_msg_part_get_u32(struct xua_msg_part *part); -uint32_t xua_msg_get_u32(struct xua_msg *xua, uint16_t iei); +uint32_t xua_msg_part_get_u32(const struct xua_msg_part *part); +uint32_t xua_msg_get_u32(const struct xua_msg *xua, uint16_t iei); void xua_part_add_gt(struct msgb *msg, const struct osmo_sccp_gt *gt); int xua_msg_add_sccp_addr(struct xua_msg *xua, uint16_t iei, const struct osmo_sccp_addr *addr); diff --git a/src/xua_msg.c b/src/xua_msg.c index 10bedb4..79c358c 100644 --- a/src/xua_msg.c +++ b/src/xua_msg.c @@ -283,13 +283,13 @@ return xua_msg_add_data(xua, iei, sizeof(val_n), (uint8_t *) &val_n); } -uint32_t xua_msg_part_get_u32(struct xua_msg_part *part) +uint32_t xua_msg_part_get_u32(const struct xua_msg_part *part) { OSMO_ASSERT(part->len >= 4); return ntohl(*(uint32_t *)part->dat); } -uint32_t xua_msg_get_u32(struct xua_msg *xua, uint16_t iei) +uint32_t xua_msg_get_u32(const struct xua_msg *xua, uint16_t iei) { struct xua_msg_part *part = xua_msg_find_tag(xua, iei); if (!part) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/22770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I517943bd11d73195de9418fb1c5d4151dab77873 Gerrit-Change-Number: 22770 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210207/cb22f07d/attachment.htm>