This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22754 ) Change subject: hide the "smscb-command" vty command; people should use osmo-cbc ...................................................................... hide the "smscb-command" vty command; people should use osmo-cbc Many years prior to the implementation of osmo-cbc, we introduced a way how raw RSL SMSCB COMMANMD can be injected from the VTY. These days, people should use the CBSP interface with osmo-cbc or any other CBC. We should not advertise the VTY command hack as a standard feature anymore. Change-Id: If5ddc3db989763a1f47d4cbc026e293e3134d8ef Related: OS#4753 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/22754/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 03b87b4..3b2bf51 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -5775,8 +5775,9 @@ return CMD_SUCCESS; } - -DEFUN(smscb_cmd, smscb_cmd_cmd, +/* this command is now hidden, as it's a low-level debug hack, and people should + * instead use osmo-cbc these days */ +DEFUN_HIDDEN(smscb_cmd, smscb_cmd_cmd, "bts <0-255> smscb-command (normal|schedule|default) <1-4> HEXSTRING", "BTS related commands\n" BTS_NR_STR "SMS Cell Broadcast\n" @@ -5840,6 +5841,7 @@ return CMD_WARNING; } + /* SDCCH4 might not be correct here if the CBCH is on a SDCCH8? */ rsl_sms_cb_command(bts, RSL_CHAN_SDCCH4_ACCH, cb_cmd, false, buf, rc); return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If5ddc3db989763a1f47d4cbc026e293e3134d8ef Gerrit-Change-Number: 22754 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210206/427a43a7/attachment.htm>