This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22748 ) Change subject: submit_to_sms(): fix the use of deprecated gsm_septets2octets() ...................................................................... submit_to_sms(): fix the use of deprecated gsm_septets2octets() Change-Id: I9985972f0b1d2b71bfd133c5004201a3a0ffcbd0 --- M TODO-RELEASE M src/libmsc/smpp_openbsc.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 9c358ae..036a9b9 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -11,3 +11,4 @@ osmo-msc Mobile Identity Coding OsmoMSC is stricter in rejecting invalid coding of Mobile Identity IEs libmosmo-mgcp-client needs osmo-mgw.git > 1.7.0 (8667d5169df8d06e10ee3f3104e4cd533d15ac57), ABI break due to struct size in mgcp_conn_peer and mgcp_response osmo-msc update version dependency to version with osmo_fd_*_{disable,enable} +osmo-msc smpp migrate to gsm_septet_pack(), available since Ib1aac538afeb0a5c76a1df472d555139a496e12e diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c index a79b252..54cd75b 100644 --- a/src/libmsc/smpp_openbsc.c +++ b/src/libmsc/smpp_openbsc.c @@ -250,8 +250,7 @@ sms_msg_len -= ud_len; padbits = 7 - (ud_len % 7); } - gsm_septets2octets(sms->user_data+ud_len, sms_msg, - sms_msg_len, padbits); + gsm_septet_pack(sms->user_data+ud_len, sms_msg, sms_msg_len, padbits); sms->user_data_len = (ud_len*8 + padbits)/7 + sms_msg_len;/* SEPTETS */ /* FIXME: sms->text */ } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9985972f0b1d2b71bfd133c5004201a3a0ffcbd0 Gerrit-Change-Number: 22748 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/5efddfeb/attachment.htm>