Change in osmo-ggsn[master]: apn_start: avoid segfault if missing tun-device

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/22732 )

Change subject: apn_start: avoid segfault if missing tun-device
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/1/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/1/ggsn/ggsn.c@186 
PS1, Line 186: 	if (!apn->tun.cfg.dev_name) {
> I would rather add this kind of check during main() after parsing VTY. […]
After parsing VTY in main() does not work, because the APN is started during parsing. As discussed, I've moved it to parsing of "no shutdown", where it does get started.

 osmo-ggsn -c broken.cfg
 Error occurred during reading the below line:
   no shutdown

 % Failed to start APN, tun-device is not configured
 Failed to open config file: 'broken.cfg'



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/22732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9f71af65cc0eed71728c04b774e5c08352947913
Gerrit-Change-Number: 22732
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 15:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/8ded57a0/attachment.htm>