This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/22732 )
Change subject: apn_start: avoid segfault if missing tun-device
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/1/ggsn/ggsn.c
File ggsn/ggsn.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/1/ggsn/ggsn.c@186
PS1, Line 186: if (!apn->tun.cfg.dev_name) {
I would rather add this kind of check during main() after parsing VTY.
It's actually the only time which this can happen: during startup. Since once it's set, the dev name is always non null, even if changed through VTY.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/22732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9f71af65cc0eed71728c04b774e5c08352947913
Gerrit-Change-Number: 22732
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 13:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/e33d53bb/attachment.htm>