Change in osmo-ttcn3-hacks[master]: pcu: Fix inadequate restriction on the referenced template parameter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 5 11:38:12 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22728 )


Change subject: pcu: Fix inadequate restriction on the referenced template parameter
......................................................................

pcu: Fix inadequate restriction on the referenced template parameter

Fixes:
warning: Inadequate restriction on the referenced template parameter
`tfi', this may cause a dynamic test case error at runtime

Same for other parameters.

Change-Id: If2cadbc7087ac0f99537b9916ef0c23363c9242c
---
M library/RLCMAC_Templates.ttcn
1 file changed, 19 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/22728/1

diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn
index 981061c..6b5fb9f 100644
--- a/library/RLCMAC_Templates.ttcn
+++ b/library/RLCMAC_Templates.ttcn
@@ -422,9 +422,12 @@
 	}
 
 	/* Template for uplink Data block */
-	template RlcmacUlBlock t_RLCMAC_UL_DATA(template CodingScheme cs, template uint5_t tfi,
-						template uint4_t cv, template uint7_t bsn,
-						template LlcBlocks blocks := {}, template boolean stall := false) := {
+	template (value) RlcmacUlBlock t_RLCMAC_UL_DATA(template (value) CodingScheme cs,
+							template (value) uint5_t tfi,
+							template (value) uint4_t cv,
+							template (value) uint7_t bsn,
+							template (value) LlcBlocks blocks := {},
+							template (value) boolean stall := false) := {
 		data := {
 			cs := cs,
 			mac_hdr := {
@@ -444,10 +447,13 @@
 			blocks := blocks
 		}
 	}
-	template RlcmacUlBlock t_RLCMAC_UL_DATA_TLLI(template CodingScheme cs, template uint5_t tfi,
-						     template uint4_t cv, template uint7_t bsn,
-						     template LlcBlocks blocks := {}, template boolean stall := false,
-						     template GprsTlli tlli) := {
+	template (value) RlcmacUlBlock t_RLCMAC_UL_DATA_TLLI(template (value) CodingScheme cs,
+							     template (value) uint5_t tfi,
+							     template (value) uint4_t cv,
+							     template (value) uint7_t bsn,
+							     template (value) LlcBlocks blocks := {},
+							     template (value) boolean stall := false,
+							     template (value) GprsTlli tlli) := {
 		data := {
 			cs := cs,
 			mac_hdr := {
@@ -469,9 +475,12 @@
 	}
 
 	/* Template for uplink Data block */
-	template RlcmacUlBlock t_RLCMAC_UL_EGPRS_DATA(CodingScheme mcs,
-						      template uint5_t tfi, template uint4_t cv,
-						      template uint11_t bsn1, template uint8_t bsn2_offset := 0, template EgprsLlcBlocks blocks := {}) := {
+	template (value) RlcmacUlBlock t_RLCMAC_UL_EGPRS_DATA(CodingScheme mcs,
+							      template (value) uint5_t tfi,
+							      template (value) uint4_t cv,
+							      template (value) uint11_t bsn1,
+							      template (value) uint8_t bsn2_offset := 0,
+							      template (value) EgprsLlcBlocks blocks := {}) := {
 		data_egprs := {
 			mcs := mcs,
 			mac_hdr := {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22728
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If2cadbc7087ac0f99537b9916ef0c23363c9242c
Gerrit-Change-Number: 22728
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/dec069e3/attachment.htm>


More information about the gerrit-log mailing list