Change in osmo-ttcn3-hacks[master]: pcu: Fix warning: The value returned by function is not used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 5 11:26:58 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22726 )


Change subject: pcu: Fix warning: The value returned by function is not used
......................................................................

pcu: Fix warning: The value returned by function is not used

Change-Id: Id7068e74439d1532c32c6113e642d0b3b063aaf3
---
M pcu/PCUIF_Components.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/22726/1

diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn
index 50de700..868012f 100644
--- a/pcu/PCUIF_Components.ttcn
+++ b/pcu/PCUIF_Components.ttcn
@@ -363,11 +363,16 @@
 		repeat;
 		}
 	[lengthof(pdtch_data_queue) > 0] CLCK.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_END)) -> value event {
+		var boolean exists;
 		/* FN matching the beginning of current block: */
 		ev_begin_fn := event.data.tdma_fn - 3;
 
 		/* Check if we reached time to serve the first DATA.ind message in the queue: */
-		f_PCUIF_MsgQueue_first(pdtch_data_queue, pcu_msg);
+		exists := f_PCUIF_MsgQueue_first(pdtch_data_queue, pcu_msg);
+		if (not exists) {
+			/* Should not happen since we end up here if lengthof(pdtch_data_queue) > 0 */
+			mtc.stop;
+		}
 		next_fn := pcu_msg.u.data_ind.fn;
 		if (next_fn != 0 and next_fn != ev_begin_fn) {
 			if (next_fn < ev_begin_fn) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22726
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7068e74439d1532c32c6113e642d0b3b063aaf3
Gerrit-Change-Number: 22726
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/aac9774a/attachment.htm>


More information about the gerrit-log mailing list