This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653 ) Change subject: gb_proxy: Simplify raid data storage ...................................................................... Patch Set 5: (3 comments) > Patch Set 4: > > (2 comments) > > > Patch Set 2: > > > > I think this mixes two orthogonal topics: > > > > a) moving from a binary to a decoded ra_id > > b) reducing redundancy between the multiple places of storage > > > > "a" is uncontroversial to me. "b" is dangerous, as without detailed review I would not be sure if bvc->cell always exists in all situations where we want to read or write the ra_id. > > re b I had a look and we should always have a cell for a given (ptp) bvc. The only place where I'm a bit unsure is when we get a ptp bvc reset from the sgsn. > > Do you want this commit split up then? There is indeed a problem. I think splitting this is the right strategy. https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/4//COMMIT_MSG@7 PS4, Line 7: gb_proxy: Simplify raid data storage > Not really needed anymore as this whole repository is about gbproxy its the name of the module gb_proxy.c https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/5/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/5/src/gb_proxy.c@1050 PS5, Line 1050: if (!bss_bvc->cell) There is indeed a problem with removing the redundancy, here I fixed a segfault/nullpointer-deref. osmo-gbproxy no longer crashes now in the TTCN3 tests but the test TC_paging_ps_sig_lac does not pass anymore. We definetly broke something, but I do not know what or where? The changes look good. Maybe we get on the ground of this when we split up the redundancy removal. https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/2/src/gb_proxy_ctrl.c File src/gb_proxy_ctrl.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/2/src/gb_proxy_ctrl.c@96 PS2, Line 96: cmd->reply = talloc_asprintf_append(cmd->reply, "%u,%u,%u,%u,%u,%u,%s\n", > I'd rather have that in a separate commit. I will fix this with the next patchset (the next after the current one I just pushed) -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ib58b9188e3ce4bd3fdadb03f158d56b29778387c Gerrit-Change-Number: 22653 Gerrit-PatchSet: 5 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 04 Feb 2021 16:07:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210204/fa72258a/attachment.htm>