Change in osmo-bsc[master]: assignment_fsm: fix possible null pointer dereference

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22678 )


Change subject: assignment_fsm: fix possible null pointer dereference
......................................................................

assignment_fsm: fix possible null pointer dereference

It assignment_success(), conn_get_bts() is called to get the BTS struct
from the connection. However, it is not checked whether the function
actually returned a pointer. The bts struct is used to check if it is a
siemens BTS using is_siemens_bts(), so lets just check before we pass on
the bts pointer.

Change-Id: I5b4f44113b24d4ee4d44f54eff87056b20a7158d
Related: CID#216933
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/22678/1

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index e5ef1c5..88083ba 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -232,7 +232,7 @@
 	conn->assignment.new_lchan = NULL;
 
 	bts = conn_get_bts(conn);
-	if (is_siemens_bts(bts) && ts_is_tch(conn->lchan->ts)) {
+	if (bts && is_siemens_bts(bts) && ts_is_tch(conn->lchan->ts)) {
 		/* HACK: store the actual Classmark 2 LV from the subscriber and use it here! */
 		uint8_t cm2_lv[] = { 0x02, 0x00, 0x00 };
 		send_siemens_mrpci(conn->lchan, cm2_lv);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5b4f44113b24d4ee4d44f54eff87056b20a7158d
Gerrit-Change-Number: 22678
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210204/f494f0da/attachment.htm>