This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22647 ) Change subject: gprs_ns2_frgre: set a correct gre pointer for ipv6 ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22647/3/src/gb/gprs_ns2_frgre.c File src/gb/gprs_ns2_frgre.c: https://gerrit.osmocom.org/c/libosmocore/+/22647/3/src/gb/gprs_ns2_frgre.c@345 PS3, Line 345: greh = (struct gre_hdr *) (msg->data + sizeof(struct ip6_hdr)); sizeof(*iph6) would be clearer for readers, since your are using that pointer in ipv6 case otherwise first it looked like msg->data was being used directly. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ff868a7bba6151a2202df774ff022c02b8c34cb Gerrit-Change-Number: 22647 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 03 Feb 2021 11:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/415530fa/attachment.htm>