Change in libosmocore[master]: gprs_ns2: unify the handling of **result when bind already present.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Feb 3 10:36:43 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22644 )

Change subject: gprs_ns2: unify the handling of **result when bind already present.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22644/1/src/gb/gprs_ns2_fr.c 
File src/gb/gprs_ns2_fr.c:

https://gerrit.osmocom.org/c/libosmocore/+/22644/1/src/gb/gprs_ns2_fr.c@725 
PS1, Line 725:  *  \return 0 on success; negative on error */
You should document the -ELAREADY case here returning the existing bind in **result. Otherwise, if it's not public, don't do it in the function.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22644
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd0c2190d2af39804c18c4786a997079db9a4330
Gerrit-Change-Number: 22644
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/abf320ca/attachment.htm>


More information about the gerrit-log mailing list