Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Feb 2 15:05:29 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )

Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
......................................................................


Patch Set 7:

The protocol version is increased because the PCUIF protocol changes at the point where we transmit the SI13 message.

We currently use the SAPI4 only for updating or revoking the SI13. The revoking of the SI13 works by sending an empty message. To extend this to a protocol where we are able to update or revoke SI1, SI3 or SI13 at the same time we need some extension. I did it the following way:

As there is an osmo_si type enum I used that as a header byte. Then the normal SI13 or SI1 or SI3 message follows. The revoking works by just sending the header byte only.

I wonder what we could do to get around bumping the PCUIF version. I think the only way would be to omit the header byte for SI13. Sending nothing would mean that only SI13 is revoked. Sending a pure SI13 with GSM_MACBLOCK_KEN would mean that SI13 is updated. All GSM_MACKBLOCK_LEN+1 messages would work by the new protocol. I find that this would be too ugly.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc
Gerrit-Change-Number: 22369
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Feb 2021 15:05:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210202/20e5984b/attachment.htm>


More information about the gerrit-log mailing list