Change in libosmo-sccp[master]: xua_msg: fix gcc 4 + -std=gnu11 error

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/22629 )

Change subject: xua_msg: fix gcc 4 + -std=gnu11 error
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/22629/1/include/osmocom/sigtran/xua_msg.h 
File include/osmocom/sigtran/xua_msg.h:

https://gerrit.osmocom.org/c/libosmo-sccp/+/22629/1/include/osmocom/sigtran/xua_msg.h@27 
PS1, Line 27: #define _XUA_HDR(class, type)	{ .spare = 0, .msg_class = (class), .msg_type = (type) }
Sofyi, I think the difference here on whether to use the " = (type) {}" vs " = {}" is wheter you are assigning the value at the same ime you are declaring the variable, or whether you are assigning (copying) from another struct of the same type later on.

I think those are really different uses, and the second one is most probably a gnu extension.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/22629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I890432ee976043d012b01023f7dd2cfecf79d115
Gerrit-Change-Number: 22629
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Feb 2021 12:43:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210202/8f308bb0/attachment.htm>