Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Feb 1 15:32:22 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )

Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 6:
> 
> (1 comment)
> 
> > Patch Set 6:
> > 
> > I hope I have found a better way now to transfer the sysinfo to the PCU. Actually there is a SAPI 4 in the PCUIF protocol through which we already send SI13. This can be extended to transfer SI1 and SI3 as well.
> 
> Nice! Would be funny it we discovered this after merging your initial approach ;) If you remove the first (redundant?) octet in DATA.ind messages, there would be no need to bump PCUIF version at all.

There would be still the problem that we would have to have a way to tell that the SI should be deleted.

Basically I understand you suggestion as follows:
- Remove osmo-si type at the beginning and use RSL IEI type.

01 06 [SI 13 octets] ==> New SI, store in struct, set si13_is_set to true
01 ==> set si13_is_set to false.

Maybe also:

(nothing) ==> set si13_is_set to false.

Sure, we can have that, but I do not see a big advantage over the now existing approach.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/6/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/6/pcu/PCU_Tests.ttcn@3589 
PS6, Line 3589: '01'O
> What is the purpose of this octet? I guess to indicate the type of SI? […]
I guess this is the IEI that is used on RSL level. All SI are prefixed with this pseudo header.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc
Gerrit-Change-Number: 22369
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 01 Feb 2021 15:32:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/c9132903/attachment.htm>


More information about the gerrit-log mailing list