Change in osmo-gsm-tester[master]: enb, epc: implement stdout/log KPI getter in eNB/EPC base class

[srs_andre]

srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601 )


Change subject: enb,epc: implement stdout/log KPI getter in eNB/EPC base class
......................................................................

enb,epc: implement stdout/log KPI getter in eNB/EPC base class

add implementation of get_stdout_kpi/get_log_kpi to base class
of EPC/eNB. The base implementation return empty KPIs by default.
The methods can be overwritten if more advanced KPI analysis is
available. But the base implementation makes sure testcases
don't fail if this isn't the case.

Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32
---
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/epc.py
2 files changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/01/22601/1

diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py
index a5bca24..43182d5 100644
--- a/src/osmo_gsm_tester/obj/enb.py
+++ b/src/osmo_gsm_tester/obj/enb.py
@@ -355,5 +355,18 @@
     @abstractmethod
     def get_counter(self, counter_name):
         raise log.Error('get_counter() not implemented!')
+    
+    # Helper methods for testcases to retrieve eNB KPIs, can be overwritten by specific classes
+    def get_stdout_kpis(self):
+        # No KPI on stdout by default
+        return {}
+
+    def get_log_kpis(self):
+        # Make sure we have the errors and warnings counter in the dict
+        return {'total_errors': 0, 'total_warnings': 0}
+
+    def get_num_phy_errors(self, kpi):
+        # Assume zero PHY errors
+        return 0 
 
 # vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/obj/epc.py b/src/osmo_gsm_tester/obj/epc.py
index 6f056fc..fb32b9e 100644
--- a/src/osmo_gsm_tester/obj/epc.py
+++ b/src/osmo_gsm_tester/obj/epc.py
@@ -116,4 +116,11 @@
     def run_node(self):
         return self._run_node
 
+    def get_stdout_kpis(self):
+        return {}
+
+    def get_log_kpis(self):
+        # Make sure we have the errors and warnings counter in the dict
+        return {'total_errors': 0, 'total_warnings': 0}        
+
 # vim: expandtab tabstop=4 shiftwidth=4

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32
Gerrit-Change-Number: 22601
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/a5582048/attachment.htm>