Change in libosmocore[master]: ns2: encapsulate calls to nsvc->bind->send_vc()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 1 08:31:36 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22557 )

Change subject: ns2: encapsulate calls to nsvc->bind->send_vc()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22557/2/src/gb/gprs_ns2_message.c 
File src/gb/gprs_ns2_message.c:

https://gerrit.osmocom.org/c/libosmocore/+/22557/2/src/gb/gprs_ns2_message.c@169 
PS2, Line 169: static int ns_vc_tx(struct gprs_ns2_vc *nsvc, struct msgb *msg)
> inline?
I'll let the compiler figure that out.  It's 2021 and I would have expected any compiler in the last 15+ years to do it by itself for a static function of this size...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8d14c7b8d3aacc2bed033072d7934dbd6aab41df
Gerrit-Change-Number: 22557
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Mon, 01 Feb 2021 08:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/4476b6e2/attachment.htm>


More information about the gerrit-log mailing list