Change in osmo-mgw[master]: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Dec 28 21:05:47 UTC 2021


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26689 )

Change subject: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization
......................................................................

mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization

The Header CRC field is 6 bits, not 8, and spans bits 7-2.

Fixes: ebb05c1f90e97d0795230e90ea49af7d084dc9fe
Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0
---
M src/libosmo-mgcp/mgcp_network.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c
index 264e263..f865dfe 100644
--- a/src/libosmo-mgcp/mgcp_network.c
+++ b/src/libosmo-mgcp/mgcp_network.c
@@ -1225,7 +1225,7 @@
 				if (data[0] == 0xe0) {
 					data[0] = 0xe4;
 					data[1] = 0x00;
-					data[2] = 0x09; /* Patch CRC Header to adapt to new header above */
+					data[2] = (0x09 << 2); /* Patch CRC Header to adapt to new header above */
 					rtp_state->patched_first_rtp_payload = true;
 					LOGPENDP(endp, DRTP, LOGL_DEBUG,
 						 "Patching over first two bytes"

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26689
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0
Gerrit-Change-Number: 26689
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211228/353d667a/attachment.htm>


More information about the gerrit-log mailing list