Change in osmo-bts[master]: phy_instance_destroy(): fix NULL pointer dereference

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Dec 28 15:35:32 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26692 )


Change subject: phy_instance_destroy(): fix NULL pointer dereference
......................................................................

phy_instance_destroy(): fix NULL pointer dereference

Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4
Fixes: OS#5377
---
M src/common/phy_link.c
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/26692/1

diff --git a/src/common/phy_link.c b/src/common/phy_link.c
index 5ad72ac..352d8f7 100644
--- a/src/common/phy_link.c
+++ b/src/common/phy_link.c
@@ -129,10 +129,12 @@
 	/* remove from list of instances in the link */
 	llist_del(&pinst->list);
 
-	/* remove reverse link from TRX */
-	OSMO_ASSERT(pinst->trx->pinst == pinst);
-	pinst->trx->pinst = NULL;
-	pinst->trx = NULL;
+	/* remove reverse link from TRX (if associated) */
+	if (pinst->trx != NULL) {
+		OSMO_ASSERT(pinst->trx->pinst == pinst);
+		pinst->trx->pinst = NULL;
+		pinst->trx = NULL;
+	}
 
 	talloc_free(pinst);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26692
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4
Gerrit-Change-Number: 26692
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211228/6a488d94/attachment.htm>


More information about the gerrit-log mailing list