This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26598/1/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26598/1/src/libosmo-mgcp/mgcp_network.c@1228 PS1, Line 1228: data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ > Shouldn't this be 0x24 (0x09 << 2)? Correct, thanks. see https://gerrit.osmocom.org/c/osmo-mgw/+/26689 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Mon, 27 Dec 2021 14:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211227/02d73ff8/attachment.htm>