Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRACING_LOGGING

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Dec 22 14:12:49 UTC 2021


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26673 )


Change subject: lint: checkpatch_osmo: ignore TRACING_LOGGING
......................................................................

lint: checkpatch_osmo: ignore TRACING_LOGGING

Don't recommend to use ftrace instead of using __func__ inside printf.
This only applies to the linux kernel, not to the Osmocom code base.

Related: OS#5087
Related: https://gerrit.osmocom.org/c/libosmocore/+/6357
Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/73/26673/1

diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index d1ce63a..8514f9c 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -70,6 +70,7 @@
 # * SPDX_LICENSE_TAG: we don't place it on line 1
 # * SPLIT_STRING: we do split long messages over multiple lines
 # * STRING_FRAGMENTS: sometimes used intentionally to improve readability
+# * TRACING_LOGGING: recommends to use kernel's internal ftrace instead of printf("%s()\n", __func__)
 # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line
 # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429)
 # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345)
@@ -108,6 +109,7 @@
 	--ignore SPDX_LICENSE_TAG \
 	--ignore SPLIT_STRING \
 	--ignore STRING_FRAGMENTS \
+	--ignore TRACING_LOGGING \
 	--ignore TRAILING_STATEMENTS \
 	--ignore UNNECESSARY_BREAK \
 	--ignore UNNECESSARY_INT \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26673
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd
Gerrit-Change-Number: 26673
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211222/8133a997/attachment.htm>


More information about the gerrit-log mailing list