Change in libosmocore[master]: conv: Fix the traceback for tail biting codes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Dec 22 09:50:41 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26657 )

Change subject: conv: Fix the traceback for tail biting codes
......................................................................


Patch Set 1:

(5 comments)

Letting Hoernchen and laforge review this one.
I'd be great perhaps having some unit test showing the difference in behavior after the fix.
Remember to fix stuff pointed out by the linter if applying.

https://gerrit.osmocom.org/c/libosmocore/+/26657/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/26657/1//COMMIT_MSG@16 
PS1, Line 16: Fixes #4508
OS#4508


https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c 
File src/conv.c:

https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c@551 
PS1, Line 551: 		for (s=0; s<decoder->n_states; s++)
spaces between s=0 and others.


https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c@552 
PS1, Line 552: 		{
{ in the same line of for.


https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c@558 
PS1, Line 558: 			for (i=n-1; i>=0; i--) 	{
spaces between s=0 and others.


https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c@579 
PS1, Line 579: 	{
{ in the same line of for.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26657
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c
Gerrit-Change-Number: 26657
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Dec 2021 09:50:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211222/577ded16/attachment.htm>


More information about the gerrit-log mailing list