Change in osmo-mgw[master]: mgcp_client: add new codec "IUUP"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Dec 21 13:54:45 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 )

Change subject: mgcp_client: add new codec "IUUP"
......................................................................


Patch Set 1:

There is a bit of a cosmetic problem when using IuUP on osmo-mgw. We need to specify a name for a codec. Usually this is something like "AMR/8000/1". As far as I understand IuUP is more an encapsulation format that comes with a header attached to the actual payload, so it is never pure AMR or anything else. Its just IuUP.

I have now defined a new codec that is called "IUUP". I couldn't find any reference in the spec which name to choose here. It seems to be unspecified. I have named the constant "CODEC_IUUP". What I am not happy with is that this is not a codec after all, so this needs to be discussed. Maybe we chose a different name for the constant like "CODEC_ANY_IUUP" or name it "PAYLOAD_IUUP". Or maybe we even add another API that allows the API user to register new codec names and then we can register "IUUP" from the application. (I think renaming all the structs from "codec_..." to "payload_..." is not an option)

Feedback is welcome.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3
Gerrit-Change-Number: 26651
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 21 Dec 2021 13:54:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211221/b6c7afd0/attachment.htm>


More information about the gerrit-log mailing list