Change in libosmocore[master]: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Dec 20 09:49:09 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26608 )

Change subject: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/26608/1/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/26608/1/src/socket.c@1827 
PS1, Line 1827: /*! string-format a given osmo_sockaddr address into a user-supplied buffer.
I think you are changing how this function used to worked here, and imho it's unexpected. I'd rather return a string filling the buffer as much as possible rather than returning NULL, similar to strlcpy, etc.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e
Gerrit-Change-Number: 26608
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Dec 2021 09:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211220/42c6f6fd/attachment.htm>


More information about the gerrit-log mailing list