This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26613 )
Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/26613/2/src/osmo-bsc/bsc_subscr_conn_fsm.c
File src/osmo-bsc/bsc_subscr_conn_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/26613/2/src/osmo-bsc/bsc_subscr_conn_fsm.c@145
PS2, Line 145: switch (conn->fi->state) {
Using an 'if' statement here would make it more readable, given that you have only one 'case'. Perhaps you're planning to add more 'case's here? Not critical though.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741
Gerrit-Change-Number: 26613
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Dec 2021 22:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211217/4af59a00/attachment.htm>