Change in libosmocore[master]: select: gather statistics for TCP connections

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Dec 17 13:03:12 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 )

Change subject: select: gather statistics for TCP connections
......................................................................


Patch Set 10:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c 
File src/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c@188 
PS9, Line 188: 	osmo_stats_tcp_osmo_fd_unregister(fd);
> so we are now converting a O(k) operation into an O(n) one. […]
Lets not make this over-complicated.


https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c 
File src/stats_tcp.c:

https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c@194 
PS9, Line 194: 		return;
> agreed
Done


https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c@210 
PS9, Line 210: void osmo_stats_tcp_osmo_fd_unregister(const struct osmo_fd *fd)
> yes, but I don't think it matters all that much. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d
Gerrit-Change-Number: 26454
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Dec 2021 13:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211217/d44b0058/attachment.htm>


More information about the gerrit-log mailing list