This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 8: Code-Review-2 (1 comment) I'm really not happy with the proposals done so far here. The presented proposals are totally invasive to the general code for no apparent reason. So in order to get a couple socket stats from a couple sockets, we interfere with the main loop with each fd being polled? this makes no sense sorry. Please come up with a system which only applies to specific sockets for which we really want this feature. https://gerrit.osmocom.org/c/libosmocore/+/26454/8/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/8/src/select.c@169 PS8, Line 169: stats_tcp_osmo_fd_register(fd); I'm sorry but this is is crazy, I see no point in registering automatically all the fds we register in the select loop. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Wed, 15 Dec 2021 16:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211215/946d5ee6/attachment.htm>