This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... library/DIAMETER_Templates: fix flags in AIR templates According to RFC 6733, section 3 "Diameter Header", if the 'R' bit is set, the message is a request. If the 'P' bit is set, the message may be proxied, relayed, or redirected. ts_DIA_AIR is a template for Authentication Information *Request*, so the 'R' bit must be set. Also, let's allow this message to be proxied, relayed, or redirected by setting the 'P' bit by default. In tr_DIA_AIR, do not match all command flags, just ensure that the message is a request. Other flags do not matter. Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index a30a565..1b3ffdb 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -891,7 +891,7 @@ template (value) charstring dest_realm := "localdomain", template (value) UINT32 hbh_id := '00000000'O, template (value) UINT32 ete_id := '00000000'O) := - ts_DIAMETER(flags := '00000000'B, + ts_DIAMETER(flags := '11000000'B, cmd_code := Authentication_Information, hbh_id := hbh_id, ete_id := ete_id, @@ -909,7 +909,7 @@ template (present) charstring dest_realm := ?, template (present) UINT32 hbh_id := ?, template (present) UINT32 ete_id := ?) := - tr_DIAMETER(flags := '11000000'B, + tr_DIAMETER(flags := '1???????'B, cmd_code := Authentication_Information, app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id := hbh_id, ete_id := ete_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211215/f4df7eff/attachment.htm>