Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Dec 15 08:50:34 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 )

Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/26463/7/firmware/Makefile 
File firmware/Makefile:

https://gerrit.osmocom.org/c/simtrace2/+/26463/7/firmware/Makefile@291 
PS7, Line 291: 	$(SILENT)misc/crctool 512 $@
To avoid what Harald wrote here:
> Should the last step fail, there will still be a .bin file and a subsequent repeated 'make' command will no longer try executing crctool, as the .bin already exists?

I suggest:
  $(SILENT)cp $< $@.temp
  $(SILENT)misc/crctool 512 $@.temp
  $(SILENT)mv $@.temp $@



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f
Gerrit-Change-Number: 26463
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Dec 2021 08:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211215/a241cda5/attachment.htm>


More information about the gerrit-log mailing list