Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 )

Change subject: First implementation of the LLSK gtp SAPI
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c 
File src/osmo-hnodeb/gtp.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c@126 
PS2, Line 126: }
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0)
             : 		goto free_ret;
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0)
             : 		goto free_ret;
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0)
> ACK about those. […]
The point is that libgtp is written for a GSN, and a hNB (nor an eNB or gNB) is no GSN.  So there may be a lot of assumptions/baggage in libgtp which has no significance/relevance here, and which may actually bite us back later on.  I at lest would be afraid about this.  90% of the code is not applicable, and half of the struct members will not be filled in as usual, as there is no control plane, nsapi, ...

Also in terms of future regressions, when somebody makes a change in libgtp (intended for a GSN) but then without thinking of this somewhat unexpected use case.

If you want to continue the libgtp route, for sure there should definitely be no sockets for v0 or v1c, and we should never pass any data to gtp_decaps{0,1c}.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366
Gerrit-Change-Number: 26503
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 14 Dec 2021 13:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211214/abae0de1/attachment.htm>